f7603f4e1c
Fix README.md example code
2018-05-19 12:37:04 -04:00
e09e9389d8
Do not write SETTINGS in response to ACKs.
...
Reported-by talgendler in Issue #42
2018-01-29 10:50:01 -05:00
444ce56efe
Add test for multiple matchers
2018-01-23 12:52:48 -05:00
cfc68f9888
Fix ugly variable name
2018-01-23 12:52:48 -05:00
e96bd75f84
Fix bug matchers are ignored except last one
2018-01-23 12:52:48 -05:00
be5b383fd5
Use IPv4 for the listener to avoid v6 failures on Travis.
2017-12-04 12:53:26 -05:00
b9e684ba4e
Fix TestClose for Go10.
...
Depending on the Go version used, reading from a closed pipe can return
net.OpError or io.ErrClosedPipe. Simply check the string content of the
error.
2017-12-04 12:53:26 -05:00
bb79a83465
Add matchers for header value prefixes
2017-08-14 16:21:37 -04:00
7e08502c7a
Merge pull request #51 from peter-edge/increase-test-timeout
...
Increase test timeout from 100ms to 500ms
2017-08-14 16:05:13 -04:00
0c129dc694
Increase test timeout from 100ms to 500ms
2017-08-14 15:22:33 -04:00
34a8ab6cda
Merge pull request #49 from tmm1/tls-matcher
...
Add TLS matcher
2017-07-20 14:14:27 -04:00
3b204bab2a
Add simple test for cmux.TLS() matcher
2017-07-20 10:56:11 -07:00
9a3402ad7a
unexport prefixByteMatcher
2017-07-19 21:45:02 -07:00
4f90533583
add TLS matcher
2017-07-19 20:08:18 -07:00
8cd60510aa
Remove V4 address family in cmux_test.go.
...
On IPv6 only machines, cmux_test.go would fail because it forces
tcp4. Simply use tcp, instead.
2017-07-03 09:35:36 -04:00
f671b41193
Merge pull request #47 from yaojingguo/issue-46
...
doc: fix a typo
2017-05-22 08:43:13 -04:00
885b8d8a14
doc: fix a typo
2017-05-22 20:38:03 +08:00
0068a46c9c
Merge pull request #45 from soheilhy/fix-44
...
Eliminate blocking reads in the HTTP2 matcher.
2017-04-24 21:57:51 -04:00
6a5d332559
Remove Go 1.5 from travis builds.
...
gRPC doesn't support Go 1.5 anymore, and the build would
fail if we keep testing with Go 1.5.
2017-04-24 21:45:35 -04:00
c0f3570a02
Eliminate blocking reads in the HTTP2 matcher.
...
The HTTP2 matcher uses io.ReadFull to read the client preface.
If the client sends a string shorter than the preface (e.g.,
SSL version) io.ReadFull will block.
Replace io.ReadFull with Read and assume partial reads will not
match
Fixes #44
2017-04-23 00:08:19 -04:00
b6ec57c1a4
Merge pull request #43 from soheilhy/dev/go18
...
Fix tests for Go 1.8+
2017-03-13 10:17:15 -04:00
79b9df6ccf
Add Go 1.8 to the travis config.
2017-03-13 09:57:57 -04:00
210139db95
Change connection closed string in tests.
...
Go 1.8 and 1.9 use different text for the connection closed error.
Use their common prefix (i.e., "use of closed") in the tests for
them to pass on all Go versions.
Go 1.8: "use of closed network connection"
Go 1.9: "use of closed file or network connection"
Suggested-by: Damien Neil <dneil@google.com>
2017-03-13 09:57:57 -04:00
bf4a8ede9e
Merge pull request #36 from soheilhy/dev/fix-mem-grow
...
Fix memory growth
2016-09-25 21:07:37 -04:00
f661dcfb59
Reset the sniffing buffer when not needed
...
The sniffing buffer will live as long as the connection is open,
and we should reset it as soon as the application has read all the
sniffed data.
2016-09-25 20:56:09 -04:00
526b64db7a
update the list of contributors.
2016-09-25 01:03:35 -04:00
3ac8d3a667
Fix lint errors in cmux_test.go
2016-09-25 00:58:27 -04:00
861c99e0fc
Return not-match on different field values in HTTP2
...
Retun as soon as we have the matched field in the HTTP2 matcher
regardless of weather the value is matched or not. Fixes #35 .
Issue #35 reports that cmux leaks memory when the client is HTTP2
but does not sends the expected header field. For example, when
the non-gRPC client sends a large field in the header and we are
matching for gRPC, we waste a lot of memory in the sniff buffer.
2016-09-25 00:58:17 -04:00
13f520d62c
Merge pull request #34 from ekle/master
...
SetReadDeadline for Matching
2016-09-05 16:05:55 -04:00
e132036cce
SetReadDeadline for Matching
2016-09-05 19:56:50 +02:00
b26951527b
Merge pull request #33 from soheilhy/fix-b32
...
Fix index out of range in patricia tree
2016-07-15 11:38:34 -07:00
eddb3b1467
Fix index out of range in patricia tree
...
Bug #32 reported that there is an index out of range error. This
issue was introduced in 703b087Fix #32 and add a test to detect this issue
2016-07-15 10:01:37 -07:00
e85da3027e
Merge pull request #30 from soheilhy/fix-patricia-tree
...
Fix race in patricia tree
2016-07-15 08:04:18 -07:00
df31d48636
Parallelize benchmarks
2016-07-14 22:03:14 -07:00
fd01d3cc6c
Fix race in patricia tree
...
This commit fixes a major issue added in 703b087a
2016-07-14 22:01:30 -07:00
f952454ed9
Add the list of contributors
...
Add the list of contributors in a separate file and add links
to the LICENSE and CONTRIBUTORS files.
Fixes #28
2016-07-09 14:07:27 -04:00
00342b4d79
Add package level docs
2016-07-09 14:01:24 -04:00
cd9b7d74b9
Add copyright notice headers on all Go files.
...
As per http://www.apache.org/legal/src-headers.html#headers
Fixes #28
2016-07-09 13:56:02 -04:00
9d1e2a64dd
Merge pull request #25 from soheilhy/devel-optimize-patricia
...
Optimize Patricia tree
2016-05-03 22:33:52 -04:00
703b087a39
Optimize Patricia tree
...
Remove all the extra allocations in the Patricia tree.
O(1) allocation for Patricia and ~10% improvement for HTTP1 matching.
benchmark old ns/op new ns/op delta
BenchmarkCMuxConnHTTP1-4 908 782 -13.88%
BenchmarkCMuxConnHTTP2-4 835 818 -2.04%
BenchmarkCMuxConnHTTP1n2-4 1074 1033 -3.82%
BenchmarkCMuxConnHTTP2n1-4 1010 901 -10.79%
benchmark old allocs new allocs delta
BenchmarkCMuxConnHTTP1-4 5 3 -40.00%
BenchmarkCMuxConnHTTP2-4 4 4 +0.00%
BenchmarkCMuxConnHTTP1n2-4 6 4 -33.33%
BenchmarkCMuxConnHTTP2n1-4 6 4 -33.33%
benchmark old bytes new bytes delta
BenchmarkCMuxConnHTTP1-4 276 272 -1.45%
BenchmarkCMuxConnHTTP2-4 304 304 +0.00%
BenchmarkCMuxConnHTTP1n2-4 306 304 -0.65%
BenchmarkCMuxConnHTTP2n1-4 308 304 -1.30%
2016-05-03 22:28:32 -04:00
d45bcbe1db
Add more benchmarks
...
Add benchmarks for HTTP2 matchers and combinations of it with HTTP1Fast.
2016-05-03 22:14:35 -04:00
9297b6de56
Merge pull request #24 from soheilhy/fix-java-client
...
Fix java gRPC client
2016-04-24 14:53:47 -04:00
dc30a14f2d
Add docs for the Java gRPC client
2016-04-24 14:52:49 -04:00
d83a667cb2
Add Matchers that can write back on the channel
...
As reported in issue #22 reports that Java gRPC clients cannot
handshake with cmux'ed gRPC server, since the client does not
immediately send a header with the content-type field. The reason
is that the java client, block on receiving the first SETTING
frame.
Add MatchWriter that can match and write on the connection. Implement
a MatchWriter that writes a SETTING frame once it receives a SETTING
frame.
2016-04-24 14:47:08 -04:00
255149b822
Merge pull request #23 from soheilhy/bytes-buffer
...
Replace TeeReader with a bytes buffer
2016-04-24 14:38:36 -04:00
3077b24d47
Fix and optimize travis config
...
There is no point in running shadow and lints for all version of go.
Also, remove 1.3 and 1.4.
2016-04-24 14:10:41 -04:00
d5924ef0b4
Fix a blocking issue in buffer reader
...
After sniffing and buffering data, if we try to read from
the socket again, bufio.Reader may block. This breaks HTTP handlers
in go1.5.2+ if one tries on browsers or with curl. Go's HTTP client,
however, is not broken. This issue is also there with TeeReader.
Return immediately with the data in the sniffed buffer.
2016-04-24 12:55:13 -04:00
59b6f01712
Replace buffer with bufferedReader
...
bufferedReader is an optimized implementation of io.Reader that behaves
like
```
io.MultiReader(bytes.NewReader(buffer.Bytes()), io.TeeReader(source, buffer))
```
without allocating.
This has a measurable effect on benchmarks:
```
name old time/op new time/op delta
CMuxConn-4 1.09µs ± 4% 0.99µs ±19% -9.32% (p=0.000 n=17+19)
name old alloc/op new alloc/op delta
CMuxConn-4 240B ± 0% 260B ± 0% +8.33% (p=0.000 n=20+20)
name old allocs/op new allocs/op delta
CMuxConn-4 9.00 ± 0% 5.00 ± 0% -44.44% (p=0.000 n=20+20)
```
Note that appropriate test coverage is provided by `TestRead`.
2016-02-28 19:41:37 -05:00
7ec7ce7ad1
Merge pull request #21 from soheilhy/devel
...
Use the readable indentation for error flow
2016-02-27 18:16:04 -05:00
e09914bfa3
Use the readable indentation for error flow
2016-02-27 13:04:49 -05:00
Alan D. Cabrera
Soheil Hassas Yeganeh
Yuki Ito
Soheil Hassas Yeganeh
Peter Edge
Soheil Hassas Yeganeh
Aman Gupta
Jingguo Yao
Andreas Jaekle
Tamir Duberstein